Remove hardcoded resource references

sreedharande / Microsoft-Sentinel-As-A-Code

Export Microsoft Sentinel artifacts like Analytical Rules, Hunting Queries, Workbooks in order to support new feature Repositories CI/CD Pipeline

MIT License

55 stars 19 forks source link

Remove hardcoded resource references #6

Closed ThijsLecomte closed 2 years ago

ThijsLecomte commented 2 years ago

When working with CI/CD, having a hardcoded subscriptionID, Resouce Group & Resource Name is a deal breaker. Can these be updated to parameters?

sreedharande commented 2 years ago

@ThijsLecomte - Do you mean in the Generated ARM Template?? Can you please elaborate

ThijsLecomte commented 2 years ago

Yes, within the generated ARM template you have the ResourceID hardcoded with contain the subscription ID, resource group etc. These should be removed as within DevOps, you mostly deploy to another resource

sreedharande commented 2 years ago

@ThijsLecomte - Thanks for quick response. I was able to see in Automation Rules - Will fix it

sreedharande commented 2 years ago

@ThijsLecomte - fixed