search

sregg / spotify-tv

Unofficial Spotify app for Android TV
GNU General Public License v2.0
45 stars 15 forks source link

Endless loading for user playlists #24

Closed josh-burton closed 8 years ago

josh-burton commented 8 years ago

This PR implements endless loading for user playlists (previously was limited to 20 items).

I've also updated some dependencies like the Gradle plugin version (to enable instant run) and the support library.

josh-burton commented 8 years ago

Not sure why the CI is failing sorry.

sregg commented 8 years ago

Thank you so much @athornz for your contribution! I'll check it out some day this week and will publish an update.

Don't worry about the CI for now. I just added it to try it out a while back...

Also, feel free to work on other missing features

josh-burton commented 8 years ago

Cool, will do :)

sregg commented 8 years ago

@athornz could this bug be related to your change: https://plus.google.com/106407155709259058450/posts/9JL4FGxpZuc

josh-burton commented 8 years ago

@sregg not sure - I hope not! But I will check tonight :)

sregg commented 8 years ago

seems like it's might be due to the new leanback support library... I just reverted back to the commit before your app.gradle change and it worked again...

josh-burton commented 8 years ago

@sregg oh that's a pain. It works on the emulator ok. I can't test on my Shield because the app crashes with a native so link error.

sregg commented 8 years ago

that's interesting, it wasn't working on my emulator either

sregg commented 8 years ago

re: the native link error: https://github.com/spotify/android-sdk/issues/122