search

srehwald / eat-api

Simple static API for some (student) food places in Munich.
https://srehwald.github.io/eat-api/
MIT License
14 stars 20 forks source link

Telegram Channel + supported locations table + FMI multiple PDFs + FMI malformed PDF name KW14/15 #31

Closed raabf closed 6 years ago

raabf commented 6 years ago

Always when I looked at the supported locations list, I was confused since the data is unaligned. So I changed the format to a table, which looks much better now. Additionally, I inserted a maps link to the address, so that you can directly open it. Beside that no data was removed or added, just reformatted.

The second part of this PR is an extension – a Telegram bot – of the list of projects using eat-api.

EDIT: I really should do that on two PR, but I forgot that I have a pending PR. If both hopefully both is accepted then it no problem, or else I will refactor.

This PR will add a loop to allow parsing multiple published PDF on the homepage: cdde43a96c54447df2a4f88f47d78c3bba36d235

Furthermore the problem with week 14/15 is fixed ebe246dc8634170566d8c229cda89a4c48e4e6ad:

Garching_Speiseplan_KW_14_20181
Garching_Speiseplan_KW_15_20181

(see the appended 1 at the end of the year)

I know it is quite hacky, but detecting all possible malformed years should be non trivial and this fix will always work if something is appended or prepended.

The last two will fix #32

srehwald commented 6 years ago

Sorry for responding that late; was on vacation. Everything seems to work and I'd say even if your fix for weeks 14/15 might be hacky, we can keep it for now. If the bistro decides to do some more weird things, we can possibly adapt it.

Please, just resolve the README conflict and I'll merge. Thanks a lot!

raabf commented 6 years ago

@srehwald Oh no problem, vocations should be enjoyed without work. Well the small merge conflict is solved.