search

sreichholf / dreamDroid

DreamDroid is an open-source enigma2 client for android based devices.
https://dreamdroid.org
GNU General Public License v3.0
108 stars 43 forks source link

Zap-view grid-layout messed up if picons enabled but some are not present #75

Open TorstenWK opened 8 years ago

TorstenWK commented 8 years ago

if the picons are enabled but some are not present the grid-layout is messed up cause of wrong cell height's.

The GridView itself is not capable of setting the height of cell's per line, so maybe a line-based layout like a ListView should be used to display the zap-view. I saw that there is already a branch in which the GridView should be replaced by RecyclerView. I think this will be a good option because setting the cell's height manually will not be a option (for me). I attached a screenshot of the zap-view to show what i mean with "messed up".

Maybe i can help to fix this issue / replace the GridView with RecyclerView. I'am not a expert in java / android, but at last i'am a professional senior software-developer but more in the C/C++ way. So i think i can get this fixed ... certainly with some additional time to learn more about this project.

device-2015-11-05-181058

sreichholf commented 8 years ago

Hi,

actually there is already a solution for this because i've stumbled across the same issue for the service list stuff.

https://github.com/sreichholf/dreamDroid/blob/master/app/src/net/reichholf/dreamdroid/view/AutoGridView.java

I'll switch the zapper to AutoGridView, that will most probably fix the issue.

sreichholf commented 8 years ago

So the whole stuff has now been migrated to RecyclerView with a GridLayoutmanager, i guess it should be OK now.