search

srendle / libfm

Library for factorization machines
GNU General Public License v3.0
1.49k stars 414 forks source link

Does the Block Structure Extension work for method=SGD? #30

Closed louisabraham closed 6 years ago

louisabraham commented 6 years ago

The docs (http://www.libfm.org/libfm-1.42.manual.pdf) say at paragraph 4.3:

BS is only supported by MCMC and ALS/CD.

However, in the source, it seems it works just fine: https://github.com/srendle/libfm/blob/master/src/libfm/libfm.cpp#L189

I tracked this line down to commit b290ad8b "Commit of libFM 1.4.2", so it is really strange.

louisabraham commented 6 years ago

My bad (https://github.com/srendle/libfm/blob/master/src/libfm/src/fm_learn_sgd.h#L62)