search

srenevey / ode-solvers

Numerical methods to solve ordinary differential equations in Rust.
BSD 3-Clause "New" or "Revised" License
64 stars 26 forks source link

Fix bug where final step wouldn't be computed if rejected by controller #13

Closed joshparallel closed 2 years ago

joshparallel commented 2 years ago

Ensure last is set to false if the last step is rejected by the controller. Previously, the last step would manually set last to true without regard to whether the controller ends up rejecting the step.

joshparallel commented 2 years ago

Could you take a look at this please @srenevey?

srenevey commented 2 years ago

Thanks for your contribution. Would you mind adding the same fix in dop853.rs?

joshparallel commented 2 years ago

Thanks for your contribution. Would you mind adding the same fix in dop853.rs?

Oh good point, c4d2ca7

joshparallel commented 2 years ago

Also, would it be possible to make a new release once this merges please @srenevey?

joshparallel commented 2 years ago

Hi @srenevey, sorry to bother you, but is merging this PR and making a new release something that can be accomplished soon? Otherwise I will probably need to update my company's codebase to point to our own fork of ode-solvers, making it less likely that fixes like this will make it upstream.

srenevey commented 2 years ago

Hey. I will merge and publish a new release by the end of day (PDT time zone).

On Aug 29, 2022, at 11:15 PM, Josh Burkart @.***> wrote:

 Hi @srenevey, sorry to bother you, but is merging this PR and making a new release something that can be accomplished soon? Otherwise I will probably need to update my company's codebase to point to our own fork of ode-solvers, making it less likely that fixes like this will make it upstream.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.

srenevey commented 2 years ago

Merged and released new version on crates.io.

joshparallel commented 2 years ago

Thank you so much!