Closed joshparallel closed 2 years ago
Could you take a look at this please @srenevey?
Thanks for your contribution. Would you mind adding the same fix in dop853.rs
?
Thanks for your contribution. Would you mind adding the same fix in
dop853.rs
?
Oh good point, c4d2ca7
Also, would it be possible to make a new release once this merges please @srenevey?
Hi @srenevey, sorry to bother you, but is merging this PR and making a new release something that can be accomplished soon? Otherwise I will probably need to update my company's codebase to point to our own fork of ode-solvers
, making it less likely that fixes like this will make it upstream.
Hey. I will merge and publish a new release by the end of day (PDT time zone).
On Aug 29, 2022, at 11:15 PM, Josh Burkart @.***> wrote:
Hi @srenevey, sorry to bother you, but is merging this PR and making a new release something that can be accomplished soon? Otherwise I will probably need to update my company's codebase to point to our own fork of ode-solvers, making it less likely that fixes like this will make it upstream.
— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.
Merged and released new version on crates.io.
Thank you so much!
Ensure
last
is set tofalse
if the last step is rejected by the controller. Previously, the last step would manually setlast
totrue
without regard to whether the controller ends up rejecting the step.