Move results out of Solver and use generic numeric code (select f32/f64)

srenevey / ode-solvers

Numerical methods to solve ordinary differential equations in Rust.

BSD 3-Clause "New" or "Revised" License

67 stars 26 forks source link

Move results out of Solver and use generic numeric code (select f32/f64) #24

Closed DarthB closed 9 months ago

DarthB commented 9 months ago

The changes in this pull request are:

Use a data structure to store the SolverResults move result as suggested in #23 works.
Overwork the code to support both f32 and f64. This fixes #20
Add a new example for a bouncing ball.

There have been many changes as the generic code needs us to write T::from(0.23).unwrap() for any number that is not zero or one. I did not find another solution but if someone knows a way to make the code a bit shorter I'm happy to hear about it.

DarthB commented 9 months ago

Thank you for the good feedback. That was my first contribution to open-source and I liked it a lot.

So if anything was meant different in the process let me know. I asked because I just saw that I did resolve your comments (I used it as todo list) and wonder if that wasn't meant that way.

Have a nice weekend Tim

srenevey commented 9 months ago

Thank you for submitting a second revision and addressing my comments. Everything looks good now.

Best, Sylvain