search

srevinsaju / Brave-AppImage

MIT License
49 stars 6 forks source link

Reaching out to the Brave Team #12

Open Xmetalfanx opened 1 month ago

Xmetalfanx commented 1 month ago

Sorry, this is not a typical "issue" but I have been wondering and reading "this is not an official release" and I understand that.

I have also seen https://github.com/brave/brave-browser/issues/1060 where people including myself (no offense) rather things be Official .... the point of this is that I am not sure if the Brave team wants to take the time to do AppImage (maybe automate them somehow too) releases .. however if you are doing them anyway ... I just wondered if there has been any "communication" between this project and it's dev(s?) and the Brave team .... where PERHAPS (I just posed the question to them) if someone else does the work and submits say PRs where eventually the work this project does anyway COULD become the "official" AppImage for the Brave browser.

I know a few people that would like to use this but (NO offense) ... we would just feel better if it was marked as "Official" by the Brave team.

In my head I am just thinking maybe just both sides reaching out is the first step to this.

Sorry, if this is way off topic .... just sort of thinking out loud here

Samueru-sama commented 1 month ago

Brave already makes a zipped build for linux, which is what is being turned into an appimage here. AKA they already did 99% of the work and are just missing running appimagetool on the zipped build and releasing that, which is what this repo is doing, there is no communication, PR or extra maintainer that is needed, all that is left is that brave adds the 5 lines of shell in their workflow to make the appimage release from the zipped build, which I already mentioned in the appimage issue.

I've recently just moved to using Zen browser, it is mostly made by a single person and it already has a working appimage.

srevinsaju commented 1 month ago

@Xmetalfanx that's a good point. I myself tried doing this couple of years ago for a popular chat client called Element, but its a pain. When working with big organizations, they may not want to maintain an extra packaging format which they might not test frequently. Assuming they distribute this first-party, they will need to run proper tests and also fix new issues, which are probably not their highest priority. As for myself, I do not use Brave AppImage any more, and doing the back and forth, adapting to their CI system could be a pain. Take a look at this issue for example. Same goes for Thunderbird, Firefox and others. I just continue doing bugfixes and patches on these pipelines because people still use them. That said, feel free to fork this, or take up the initiative for getting this upstream. I will try to provide support (as much as I can, with the time I have) to help this become official.