srevinsaju / Brave-AppImage

MIT License
49 stars 6 forks source link

Bug: light mode unavailable #4

Open mj162 opened 3 years ago

mj162 commented 3 years ago

@srevinsaju Thank you for providing these AppImages; your work is sincerely appreciated!

I have the reverse problem to Bugfix: dark mode broken for settings when strict fingerprinting in v1.31.58 in which there is no brave://settings/appearance setting for theme; the app runs in dark mode -- loved by some but disliked by others -- and cannot be changed.

srevinsaju commented 2 years ago

@mj162 Weird, I cannot reproduce. locally, I am able to switch between light mode and dark mode. Looks like there is some problem with the local configuration (~/.config)

mj162 commented 2 years ago

@srevinsaju, just seen @jshroads's post reporting the same problem. To clarify, intentionally run all browsers in Guest/Incognito/Private mode. Therefore the reported behaviour is when the config is set to launch Brave in Guest mode.

(There is no brave://settings/appearance setting for theme in Guest mode in v1.31.58, v1.33.85 or v1.35.89.)

I am launching with a 'clean' ~/.config/brave since $HOME is exported in the launcher as /tmp/$USER:-

$DBUS "$exe" --no-default-browser-check --enable-ftp  --enable-site-settings \
             --guest --homedir="$HOME" --profile-directory="$HOME" --user-data-dir="$HOME" \
             --force-device-scale-factor=$QT_SCALE_FACTOR --window-size=940,1280 \
             --window-position=1200,200 --homepage https:/lite.duckduckgo.com/lite "$@" > /dev/null 2>&1 &

TIA.