search

srevinsaju / Brave-AppImage

MIT License
49 stars 6 forks source link

can't use appimageupdatetool to check or update appimage #7

Closed everyTiiNG closed 2 years ago

everyTiiNG commented 2 years ago 
$ appimageupdatetool -d brave
Fetching release information for tag "$BRAVE_TYPE" from GitHub API.

Parsing file: brave
AppImage type: 2
Raw update information: gh-releases-zsync|srevinsaju|Brave.AppImage|$BRAVE_TYPE|Brave*.AppImage.zsync
Update information type: ZSync via GitHub Releases
Failed to assemble ZSync URL. AppImageUpdate can not be used with this AppImage. See below for more information
GitHub API request failed: HTTP status 404, CURL error: %

https://github.com/srevinsaju/Brave-AppImage/blob/1aa69615137597d17be72db2b47159e0201a901e/.github/workflows/main.yml#L73

should it be double quote to expand $BRAVE_TYPE and srevinsaju|Brave-AppImage?

        ./appimagetool-x86_64.AppImage --comp gzip "$APPDIR" -n -u "gh-releases-zsync|srevinsaju|Brave-AppImage|$BRAVE_TYPE|Brave*.AppImage.zsync"
srevinsaju commented 2 years ago

Thanks for the issue! I missed it :(