search

srg-imperial / SaBRe

Load-time selective binary rewriting
Other
152 stars 16 forks source link

Switch asm to MIT license and move to plugin_api/ #73

Closed jasonwhite closed 2 years ago

jasonwhite commented 2 years ago

These files need to be statically linked into plugins. Since they're GPL-3, that means the plugin itself would also need to be GPL-3. This isn't really feasible in many cases and so MIT is a much better fit for these files.

andronat commented 2 years ago

I was actually moving those myself here but let's merge these!

jasonwhite commented 2 years ago

@andronat Oops! Didn't see that one. Thanks for merging this!

ccadar commented 2 years ago

@andronat @jasonwhite I don't think you should have merged this before hearing back from @parras who (co-)authored them. Could you please revert it until we hear back?

ccadar commented 2 years ago

Note that the license you updated previously in #64 was for a file only authored by you, I approved it, and we waited for others to comment. We should follow a similar process here, especially with files (co-)authored by others. I also know @parras had concerns about the license so I'd like to explicitly hear from him.

@parras let us know you thoughts. If I don't hear from you on GitHub, I'll try email. On my side, I support this change, as I understand that we should allow plugin code to be private. And the benefits for SaBRe are that the core will continue to receive updates, under the current GPL 3 license.

andronat commented 2 years ago

I’ll revert it asap for the 2 files i’m not the sole author. For ‘clone3’ we are ok.

parras commented 2 years ago

@ccadar Thanks for pinging me over this! I agree with you, plugin code can be private, as long as the core SaBRe stays under GPLv3. So this MR is fine with me, no need to revert it!

ccadar commented 2 years ago

Thanks for the quick reply, @parras, that's great. And thanks, @andronat and @jasonwhite for the recent useful changes!