srgantmoomoo / postman

minecraft anarchy client :)
https://techale.github.io/postman-website/
MIT License
179 stars 45 forks source link

discordRPC notification #48

Closed LarryTheFatCat closed 2 years ago

LarryTheFatCat commented 2 years ago

You don't have to merge, but I just really like having notifications whenever I start/stop discordRPC :D

LarryTheFatCat commented 2 years ago

And another thing, is the postman notification supposed to be a gray italic @postman {Message}?

LarryTheFatCat commented 2 years ago

Another thing, if it causes nullpointerexception lmk Discord: Two#6969

srgantmoomoo commented 2 years ago

i like it, could you use the notification module to do it instead tho, something like NotificationModule.INSTANCE.sendNoti("starting discordRPC... :)");... the color may just be grey for now but ill do something with noti colors in a little bit so you dont have to do anything with it just yet.

...as seen here

srgantmoomoo commented 2 years ago

i like it, could you use the notification module to do it instead tho, something like NotificationModule.INSTANCE.sendNoti("starting discordRPC... :)");... the color may just be grey for now but ill do something with noti colors in a little bit so you dont have to do anything with it just yet.

...as seen here

also i only use a notified boolean in that module that i linked because it's in onUpdate(), you don't have to do that.

srgantmoomoo commented 2 years ago

now that i think of it, this would probably be redundant since i'll have individual notifications for each module being enabled/disabled. but eh, if u do it ill accept the pr anyways if u want lol.

LarryTheFatCat commented 2 years ago

I see,

i like it, could you use the notification module to do it instead tho, something like NotificationModule.INSTANCE.sendNoti("starting discordRPC... :)");... the color may just be grey for now but ill do something with noti colors in a little bit so you dont have to do anything with it just yet.

...as seen here

Oh yes, I didn't see those classes, should've done some exploring before I made that, welp I'll experiment a bit and see if that works I'll post here incase I do work

LarryTheFatCat commented 2 years ago

now that i think of it, this would probably be redundant since i'll have individual notifications for each module being enabled/disabled. but eh, if u do it ill accept the pr anyways if u want lol.

Good point, dw about accepting it

LarryTheFatCat commented 2 years ago

Another thing, Chat mode in notification does nothing? Is this an issue on my end? hud by drawing it into the hud list, but chat has nothing, has it been finished? idk if you store the different modes into separate classes

LarryTheFatCat commented 2 years ago

Update, checked the code, and it's not finished (I think) 💀

srgantmoomoo commented 2 years ago

hmmm it should work. you have to make sure notification module itself is toggled on, aswell as the mode being set to chat.

in the case of autogap, to see the notification, you can set mode to always and turn on switchToGap, then if there is no gapple in ur inventory you should see the message.

srgantmoomoo commented 2 years ago

hmmm it should work. you have to make sure notification module itself is toggled on, aswell as the mode being set to chat.

in the case of autogap, to see the notification, you can set mode to always and turn on switchToGap, then if there is no gapple in ur inventory you should see the message.

hud mode does not do anything as of now tho.

LarryTheFatCat commented 2 years ago

hmmm it should work. you have to make sure notification module itself is toggled on, aswell as the mode being set to chat.

https://user-images.githubusercontent.com/83801755/162113420-0fe806aa-fefc-4bd9-bbb1-1112d87f423f.mp4

well, yeah notification is toggled on, mode is also set to chat, I enable a module -> no message. I tried binding a module to a keyBind and trying again, still nothing and, yes discordRpc msg does work, bc I had to send the msg via Main.INSTANCE.commandManager.sendClientChatMessage("starting discordRPC... :)", true); Which, yeah doesn't make sense to pass a msg via commandManager, but I tried in the notificationClass, still didn't work

srgantmoomoo commented 2 years ago

oh, yea no... module enabling and disabling does nothing rn for notifications, i have not added it yet.

LarryTheFatCat commented 2 years ago

oh, sorry for the bother then lol

srgantmoomoo commented 2 years ago

all good lol