search

srggrs / assign-one-project-github-action

Automatically add an issue or pull request to specific GitHub Project(s) when you create and/or label them.
MIT License
169 stars 60 forks source link

Add position input #81

Open andrenarchy opened 2 years ago

andrenarchy commented 2 years ago

Fixes #54.

srggrs commented 2 years ago

Hi @andrenarchy thanks for this! Did you tested?

andrenarchy commented 2 years ago

Yes, I tested this both with position: bottom and without the position input (in which case the request for moving the card is not made so it's backwards-compatible).

javierm commented 2 years ago

Hi, @srggrs. I'm interested in this feature since we like prioritizing pull requests from top to bottom and we give less priority to the most recent ones. Is there anything I can help with? Maybe testing this pull request?

srggrs commented 2 years ago

Hi, @srggrs. I'm interested in this feature since we like prioritizing pull requests from top to bottom and we give less priority to the most recent ones. Is there anything I can help with? Maybe testing this pull request?

Please go on and test this functionality thx!

javierm commented 2 years ago

Hi, @srggrs.

I've tested the andrenarchy/assign-one-project-github-action@master action. Everything seems to work as expected:

Out of the (about 15?) tests I've done, only once I've seen a strange behavior: a card was added to the top, then moved to the bottom, and then moved to the top again. I wonder whether it was a mere glitch on github and maybe after refreshing the page the card would have been at the bottom (as expected) :thinking:.

Here's a video showing one of the tests: in this case, draft pull requests are added to the top of the "doing" column (no position parameter) and regular pull requests are added to the bottom of the "reviewing" column (position: "bottom"). Even if there are only two pull requests per column in the video, I've also done tests with more pull requests and it worked fine as well.

After reopening pull requests, they're automatically assigned to the right position in the kanban

Hope this helps!