Support Other CGI Modules

srguglielmo commented 7 years ago

mod_fastcgi, a 3rd party Apache module released under a custom open-source license. Website offline, not sure if this is supported upstream (but there seem to be forks around).
mod_fcgid, originally 3rd party, but moved to Apache core in 2009.
mod_proxy_fcgi, new in Apache 2.4, officially part of Apache core.

See mitcho/shibboleth#13

srguglielmo commented 6 years ago

Hi @jrchamp and @cjbnc,

I believe e0d52eb0218484a142a67e3ed80242ec2927c4bb should fix this issue by allowing the customization of attributes. Could you take a look and let me know if it addresses the issue?

Thanks! Steve

jrchamp commented 6 years ago

The two functions referencing the private member variable should use $this->Attributes.

By customization, you still mean "edit the code to set new hardcoded values". It's in one place instead of two now, but that does not reduce the overall level of difficulty to maintain across disparate systems.

As far as addressing the issue, I would say 'no'. We use a standard configuration for the Shibboleth attributes and this Issue is about supporting multiple modules simultaneously, so by not applying the same transformations as in the original patch to the configured attributes names, it cannot work for multiple modules without also making changes to the code to match the chosen module.

srguglielmo / SimpleShib

Support Other CGI Modules #2