search

srhinos / primelooter

A small python bot which automatically claims amazon prime gaming loot :D
GNU General Public License v3.0
52 stars 3 forks source link

[FEAT] Use version tags for packages #13

Open Tiippex opened 2 years ago

Tiippex commented 2 years ago

I think using the latest tag as a version is quite often a bad thing to work with.

Before copy-pasting reasons to avoid the latest tag I would like to refer to this article here: https://vsupalov.com/docker-latest-tag/

It would be very kind if you add tags for the packages as well. Thanks!

srhinos commented 2 years ago

from the blog post:

If you’re a developer, are building images locally for your own consumption and are careful about it - :latest can be a reliable way to save effort and frustration. However, you should not use it for deployments as that practice will backfire badly, repeatedly and in many interesting ways.

This is not something someone is deploying in any kind of production environment, its an automation script that aims to be relatively easy to run, idempotent, and easily forgetten as rewards come in. I think :latest can be a reliable way to save effort and frustration is a bigger plus than any kind of issues that could arise from it and will probably not make an effort to move to using other kinds of tags until docker standards dictate that :latest is an invalid pattern.

srhinos commented 2 years ago

Do want to say thank you for opening a ticket on this, I didn't know there was a movement to move away from :latest for tags in prod environments and it totally makes sense in that specific case. I think my work might have our ECR deploys utilize latest for our k8s deploy so I'm gonna have to check that out tomorrow!

Tiippex commented 2 years ago

Could you reopen the ticket and assign it to me, please? I would like to dive a bit into the GitHub actions and create a PR.

from the blog post:


If you’re a developer, are building images locally for your own consumption and are careful about it - :latest can be a reliable way to save effort and frustration.

I didn't read so far :D

Do want to say thank you for opening a ticket on this, I didn't know there was a movement to move away from :latest for tags in prod environments and it totally makes sense in that specific case. I think my work might have our ECR deploys utilize latest for our k8s deploy so I'm gonna have to check that out tomorrow!

Do you use Terraform, Cloudformation... in combination with Helm charts?

srhinos commented 2 years ago

Could you reopen the ticket and assign it to me, please? I would like to dive a bit into the GitHub actions and create a PR.

from the blog post:

If you’re a developer, are building images locally for your own consumption and are careful about it - :latest can be a reliable way to save effort and frustration.

I didn't read so far :D

Do want to say thank you for opening a ticket on this, I didn't know there was a movement to move away from :latest for tags in prod environments and it totally makes sense in that specific case. I think my work might have our ECR deploys utilize latest for our k8s deploy so I'm gonna have to check that out tomorrow!

Do you use Terraform, Cloudformation... in combination with Helm charts?

Reopened! We use AWS's CDK in combination with Helm Charts and some other stuff, not entirely sure. Not on the devops side of things