srid / ema

Change-aware static site generator for Haskell programmers
https://ema.srid.ca
GNU Affero General Public License v3.0
117 stars 9 forks source link

restrictive upper bound on base #156

Closed maralorn closed 11 months ago

maralorn commented 1 year ago

See: https://hydra.nixos.org/build/228038654/nixlog/1/tail

sophicshift commented 1 year ago

More generally, dependency bounds of ema-related packages (including lvar and unionmount) are missing or not following https://pvp.haskell.org/. In most cases bounds should be of the form >= x.x.x && < x.x

srid commented 1 year ago

Happy to accept PRs adding those version bounds. I have just been lazy in this regard because these packages are pinned by Nix.

I'll make a new release of Ema, emanote, heist-extra, unionmount, etc. with these changes.

maralorn commented 1 year ago

Happy to accept PRs adding those version bounds. I have just been lazy in this regard because these packages are pinned by Nix.

Yeah, I know. I was actually wondering whether there is something you/we can do to be more preemptive on bounds. To be honest this comment I wrote a while ago on the Haskell discours mainly relates to my experience maintaining your packages, because you are such a Nix power user.

srid commented 11 months ago

https://github.com/srid/ema/commit/3c96f445ebd8b278d82e91237a3157e418279ad0

(I just noticed that my 'forever' relaxation is not applied to all .cabal packages; will address that latter)