Open johnhampton opened 3 months ago
Oh man, buildFromSdist
is causing problems once again 😔 cc @roberth
(I'm travelling; will be a while to look into this further)
I haven't looked into this in detail, but I suspect that a short-term fix would be to eval appendPatches
after buildFromSdist
(just as we do with removeReferencesTo
):
Maybe also make sure that buildFromSdist
is not used when the source is already a tarball and therefore presumably an sdist?
buildFromSdist
. I don't foresee patching local packages, but would I ever want to enable buildFromSdist
for a remote package with packages.*.source
pointing to a GitHub repository?If fixing buildFromSdist
isn't possible, it would be helpful to show an error or warning when both buildFromSdist
and patches
(or any other invalid option) are enabled together.
291 if someone were to apply patches on a local package (is that an use-case we should support?).
Might be useful as an escape hatch if the local build needs to be different from the packaged build for some (bad) reason.
The
haskell-flake
is trying to apply patches twice. The issue seems to be in the newbuildFromSDist
implementation. SettingbuildFromSDist
tofalse
resolves the problem. For a reproduction, visit https://github.com/johnhampton/haskell-flakes-double-patch.