search

srid / haskell-flake

A `flake-parts` Nix module for Haskell development
https://community.flake.parts/haskell-flake
MIT License
128 stars 14 forks source link

buildFromSdist: enable only for local packages #298

Closed srid closed 3 months ago

srid commented 3 months ago

https://github.com/srid/haskell-flake/pull/291#issuecomment-2033350702

Resolves #292

shivaraj-bh commented 2 months ago

was it intended to be defaults.settings.defined here? or was it supposed to be defaults.settings.local?

srid commented 2 months ago

It should be defined.

Wait, the last PR reverted this change, no?

I see this under settings.all:

https://github.com/srid/haskell-flake/blob/e43bc631b413078ffe7b772850005596f7295050/nix/modules/project/defaults.nix#L197

shivaraj-bh commented 2 months ago

Wait, the last PR reverted this change, no?

Shoot, I messed up while resolving merge conflict