srid / neuron

Future-proof note-taking and publishing based on Zettelkasten (superseded by Emanote: https://github.com/srid/emanote)
https://neuron.zettel.page
GNU Affero General Public License v3.0
1.52k stars 150 forks source link

Use emojis only if terminal supports it #563

Closed srid closed 3 years ago

srid commented 3 years ago

This is an extension of #555

On GitHub actions, we see emojis getting replaced with question marks, which is obviously useless and confusing.

image

https://github.com/srid/neuron-template/runs/1962405074

We should display error/warn/etc. markers in absence of emojis.

forketyfork commented 3 years ago

I noticed that emojis worked fine in GitHub actions before the build was dockerized: https://github.com/srid/neuron-template/runs/1942559665?check_suite_focus=true And starting with "Build using docker", there are only question marks: https://github.com/srid/neuron-template/runs/1962405074?check_suite_focus=true So this may as well be a dockerization issue, e.g. wrong or absent LANG setup in Dockerfile.

srid commented 3 years ago

Closing per https://neuron.zettel.page/next ... to further discuss this idea, post in Emanote repo.