srid / nixci

Define and build CI for Nix projects anywhere; superceded by Omnix https://omnix.page/om/ci.html
GNU Affero General Public License v3.0
108 stars 5 forks source link

We should `nix flake check`? #88

Closed srid closed 1 month ago

srid commented 1 month ago

Not all checks are done by building a derivation (what nixci build does currently).

For eg., nix flake check tests for unknown properties in templates.* and errors out:

https://github.com/NixOS/nix/blob/babfd0cd99012df9d645d38e47fa31d049bf01d8/src/nix/flake.cc#L550-L554

image

The above will not be caught by nixci build.

Do we care to support this niche case, though?

--

More generally, nix flake check does a bunch of "Evaluation checks":

image
srid commented 1 month ago

I wonder if we can decouple these checks through flake-schemas.

srid commented 1 month ago

Moved to https://github.com/juspay/omnix/issues/200