search

sriharshaarangi / BatteryChargeLimit

GNU General Public License v3.0
382 stars 104 forks source link

hidden charge state in OnePlus 5T #104

Closed ZoharML closed 6 years ago

ZoharML commented 6 years ago

There is some kind of a bug in the 5T roms that allows it to take charge from the USB cable even when "charging_enabled" = 0 When this happens the charge icon will not change to charge and the battery % will not get higher! it is possible to recognize this state according to \sys\class\power_supply\battery\current_now that will change to negative values. at this state changing the value of /sys/class/power_supply/battery/input_suspend to 0 and then back to 1 will stop this hidden charge state.

This state will only show up from time to time. I did not found the logic after it.

More info can be found at: https://forum.xda-developers.com/showpost.php?p=76050666&postcount=1770 https://forum.xda-developers.com/showpost.php?p=76102724&postcount=1774

Thanks for your work, Zohar

sriharshaarangi commented 6 years ago

It is unfortunate to see OEMs screwing up working logic of the files. That's a great find! This should become an additional option in the 'Advanced Settings'

ZoharML commented 6 years ago

Apparently this bug/problem is not only software driven. Since my first log I kept working on this and found out that my night wall charger was part of the problem. I've replaced my charger to a quick charge 2 (it gives me ~7Watt if I remember correctly) (I do not use the dash fast charger). After this replacement I did not had any of this hidden charges any more. I'm using my tasker program all this time and in my log file I stopped seeing this hidden charge errors. I rarely charge with other charges, but none of them gave me that bug in the log.

My current idea for this is that there is some communication from the phone to the charger telling him it's time to stop sending charge. maybe there is a combination of phone/charger implementation that make this hidden charge appear.

If you have a need for this, I can run some test for you with my old charger. Zohar

milux commented 6 years ago

Changed categorization to "future work", because it will require checking another file, which is a) likely not available across all devices. b) could cause other unforeseen consequences and weird bugs with devices that have again a completely different logic for this matter.

sriharshaarangi commented 6 years ago

@ZoharML , as you stated in https://forum.xda-developers.com/showpost.php?p=76158248&postcount=1776, there is no definite solution to this problem right?

ZoharML commented 6 years ago

I could not find a "cure" that will fix the problem at 100% of the time. I did find the control files that can detect that the phone is in this state (at least for the 5T).

What relay fixed the problem for me was to stay away from my old charger. It was a "travel adapter" model MCS-04WR, output 5V@1A, it came with my old LG phone.

sriharshaarangi commented 6 years ago

Since this is not an issue with app, and there is no solution to this problem, I will be closing this issue.