search

sriharshaarangi / BatteryChargeLimit

GNU General Public License v3.0
382 stars 104 forks source link

Allow parameter `intent` in ForegroundService#onStartCommand to be null #109

Closed angelsl closed 6 years ago

angelsl commented 6 years ago

Parameter intent of Service#onStartCommand can be null.

Fixes the following crash:

04-23 19:37:04.184 11214 11214 E AndroidRuntime: FATAL EXCEPTION: main
04-23 19:37:04.184 11214 11214 E AndroidRuntime: Process: com.slash.batterychargelimit, PID: 11214
04-23 19:37:04.184 11214 11214 E AndroidRuntime: java.lang.RuntimeException: Unable to start service com.slash.batterychargelimit.ForegroundService@a8c85ec with null: java.lang.IllegalArgumentException: Parameter specified as non-null is null: method com.slash.batterychargelimit.ForegroundService.onStartCommand, parameter intent
04-23 19:37:04.184 11214 11214 E AndroidRuntime:        at android.app.ActivityThread.handleServiceArgs(ActivityThread.java:3635)
04-23 19:37:04.184 11214 11214 E AndroidRuntime:        at android.app.ActivityThread.-wrap20(Unknown Source:0)
04-23 19:37:04.184 11214 11214 E AndroidRuntime:        at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1791)
04-23 19:37:04.184 11214 11214 E AndroidRuntime:        at android.os.Handler.dispatchMessage(Handler.java:106)
04-23 19:37:04.184 11214 11214 E AndroidRuntime:        at android.os.Looper.loop(Looper.java:164)
04-23 19:37:04.184 11214 11214 E AndroidRuntime:        at android.app.ActivityThread.main(ActivityThread.java:6753)
04-23 19:37:04.184 11214 11214 E AndroidRuntime:        at java.lang.reflect.Method.invoke(Native Method)
04-23 19:37:04.184 11214 11214 E AndroidRuntime:        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:482)
04-23 19:37:04.184 11214 11214 E AndroidRuntime:        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:807)
04-23 19:37:04.184 11214 11214 E AndroidRuntime: Caused by: java.lang.IllegalArgumentException: Parameter specified as non-null is null: method com.slash.batterychargelimit.ForegroundService.onStartCommand, parameter intent
04-23 19:37:04.184 11214 11214 E AndroidRuntime:        at com.slash.batterychargelimit.ForegroundService.onStartCommand(Unknown Source:2)
04-23 19:37:04.184 11214 11214 E AndroidRuntime:        at android.app.ActivityThread.handleServiceArgs(ActivityThread.java:3618)
04-23 19:37:04.184 11214 11214 E AndroidRuntime:        ... 8 more
angelsl commented 6 years ago

N.B. this fixes #81