srikanth-lingala / zip4j

A Java library for zip files and streams
Apache License 2.0
2.06k stars 310 forks source link

Avoid implementing Crypto-Algorithms by yourself #519

Open oli-h opened 11 months ago

oli-h commented 11 months ago

In package net.lingala.zip4j.crypto you implemented well known crypto-algprithms:

Both are offered out-of-the-box in JDK's javax.crypto library. Propose to use those as they are well tested and established - and potentially faster.

jpstotz commented 11 months ago

There is already a PR that implements those changes: #449 unfortunately without any comment or response.