search

sripathikrishnan / redis-rdb-tools

Parse Redis dump.rdb files, Analyze Memory, and Export Data to JSON
https://rdbtools.com
MIT License
5.07k stars 739 forks source link

Warn users when python-lzf is not installed #110

Closed sripathikrishnan closed 6 years ago

sripathikrishnan commented 6 years ago

Decompressing LZF strings from the rdb file takes a significant amount of time. The python-lzf package is a native c module that significantly speeds up decompressing. Without this package, rdbtools uses a pure-python method to decompress string, and this is excruciatingly slow.

With this pull request, we update the readme to also install python-lzf from pip. Additionally, if we detect that lzf is not installed, we warn the users and provide instructions to install it.

itamarhaber commented 6 years ago

Author returns! :)

oranagra commented 6 years ago

@sripathikrishnan welcome back. are you waiting for me to merge these?

sripathikrishnan commented 6 years ago

@oranagra I was looking for a review and some feedback, I think you provided some in the other pull request. Thanks!