Can't place calls on freephonie

[GoogleCodeExporter]

--
What steps will reproduce the problem?
1. Register on freephonie.net instead of pbxes.org
2. Try to place a call

What is the expected output? What do you see instead?
Dialing is expected, instead the call is dropped.

What version of the product are you using? On what operating system?
Any version > r386.

Please provide any additional information below.
I had already reported this issue a few days ago, but I mistakenly thought
it was a duplicate of issue #221.
In fact, the problem comes from the register agent. I've attached a diff
that fixes this issue, although I'm not sure that's the most elegant solution.

Original issue reported on code.google.com by lambert.sartory on 20 Jan 2010 at 10:58

Attachments:

• Freephonie_registration_fix.diff

[GoogleCodeExporter]

Original comment by pmerl...@googlemail.com on 21 Jan 2010 at 2:43

• Changed state: Duplicate

[GoogleCodeExporter]

Can you find out which lines (the branch or the via) are the relevant ones of 
your 
patch for freephonie, please?

Original comment by pmerl...@googlemail.com on 21 Jan 2010 at 9:33

[GoogleCodeExporter]

Sure, I'll have a look.

Original comment by lambert.sartory on 21 Jan 2010 at 9:38

[GoogleCodeExporter]

I tried reducing the condition to the branch part, but calls are dropped again.
I'm not sure where the problem lies exactly, but freephonie is known for not 
following 
the standards very closely.
So, the first patch is good I believe. I'm not too fond of kludges like these, 
but 
freephonie isn't going to change their SIP implementation anytime soon.

Original comment by lambert.sartory on 21 Jan 2010 at 10:25

[GoogleCodeExporter]

Try the following patch:
### Eclipse Workspace Patch 1.0
#P SipUA
Index: src/org/sipdroid/sipua/RegisterAgent.java
===================================================================
--- src/org/sipdroid/sipua/RegisterAgent.java   (revision 410)
+++ src/org/sipdroid/sipua/RegisterAgent.java   (working copy)
@@ -568,6 +568,7 @@
            ViaHeader vh=req.getViaHeader();
            String newbranch = SipProvider.pickBranch();
            vh.setBranch(newbranch);    
+           req.removeViaHeader();
            req.addViaHeader(vh);

            if (handleAuthentication(respCode, resp, req)) {

Original comment by pmerl...@googlemail.com on 21 Jan 2010 at 10:27

[GoogleCodeExporter]

Original comment by pmerl...@googlemail.com on 21 Jan 2010 at 10:30

• Changed state: FutureRelease

[GoogleCodeExporter]

Yes, this patch works indeed !
And it's much cleaner. ;)

Original comment by lambert.sartory on 21 Jan 2010 at 10:45

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

Original comment by pmerl...@googlemail.com on 27 Jan 2010 at 10:54

• Changed state: Fixed