search

srish / gerrit-newcomer-bot

Newcomer bot for Wikimedia Foundation’s Gerrit
MIT License
7 stars 1 forks source link

New (?) user not added to newcomers group automatically #10

Open aklapper opened 6 years ago

aklapper commented 6 years ago

I would have expected the bot to add a "Welcome!" comment to https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/examples/+/440739/ which is listed under https://gerrit.wikimedia.org/r/#/q/owner:%22Tuxin+%253Ctuxin%2540free.fr%253E%22

However, that user is not be in the newcomers group as can be seen at https://gerrit.wikimedia.org/r/#/q/ownerin:newcomers+owner:%22Tuxin+%253Ctuxin%2540free.fr%253E%22

Looking into Bitergia, author_name:"Tuxin" shows no previous results so I wonder why that user was not added to the newcomers group.

srish commented 6 years ago

@aklapper I am not entirely sure why specifically for the project /mediawiki/extensions/examples as in this case and the one you previously reported, the bot didn't work.

We didn't earlier have logging setup for the bot, but now I've pushed a fix and will monitor the logs. So, I will only know what happened when someone uploads a patch to that repository.

aklapper commented 6 years ago

(Bot worked in https://gerrit.wikimedia.org/r/#/c/441640/ as expected.)

aklapper commented 6 years ago

We didn't earlier have logging setup for the bot, but now I've pushed a fix and will monitor the logs. So, I will only know what happened when someone uploads a patch to that repository.

The bot did not add a comment to https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/examples/+/447618/ and https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/examples/+/448010/ and https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/examples/+/448011/

And I do not know how to reopen tickets in Github. :)

srish commented 6 years ago

Thanks for reporting @aklapper.. investigating it!

Looks like an error occurred while watching patchsets; most likely due to a timeout issue with the paramiko client like in https://github.com/fabric/fabric/issues/1610. Because of which the bot had unfortunately stopped running quite a while ago and I didn't know :-/

As a first step, integrated Twilio messaging so that whenever there is an error, I could learn about it soon and restart the bot.

aklapper commented 6 years ago

Might really be about the examples repo, worked as expected in https://gerrit.wikimedia.org/r/#/c/451239/

aklapper commented 6 years ago

Worked as expected in https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/examples/+/452201/

aklapper commented 5 years ago

Wondering how long it should take the bot to kick in on https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/examples/+/469559/

srish commented 5 years ago

From the logs, it looks like in this case the bot detected the patch owner as a new contributor instead of first-time contributor. I cannot tell more but guessing this might be a result from resetting of a dropped connection. I will investigate this more if we see a pattern repeat!

aklapper commented 5 years ago

(Same wondering about https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/examples/+/471527/ )

aklapper commented 5 years ago

(Same wondering about https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/examples/+/474093/ )

aklapper commented 5 years ago

Is this bot still active? https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/examples/+/477616/

srish commented 5 years ago

Sorry for ignoring the previous reports. I might have to seek help from someone who understands the underline structure of paramiko (http://www.paramiko.org/) more than I do and help figure out why we are running into this issue.

@aklapper any thoughts on who we could ask for help?

aklapper commented 5 years ago

Another recent example: https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/examples/+/515021/

No idea who to ask, sorry...