search

srivastavaanurag79 / react-native-paper-select

Dropdown using React Native Paper TextInput, Checkbox and Dialog
https://anurag-srivastava.gitbook.io/react-native-paper-select/
MIT License
52 stars 18 forks source link

Improvement: Allow separation of dialog title from input label #11

Closed Thodor12 closed 2 years ago

Thodor12 commented 2 years ago

Use case

In some scenarios you do not want a label on your input, in my case I have a separate label above the input as per design requirements. The drawback of not providing a label is that the dialog does not get a title either because this is linked to the same property.

Changes

Provided a new property dialogTitle along with the necessary types and implementation in the dialog.

Backwards compatability has been thought of so the property has been declared optional and it defaults back to label if not provided in order to retain original functionality.

I also updated the README to include the new property.

srivastavaanurag79 commented 2 years ago

Well a good addition. 👌