srl-freiburg / pedsim_ros

Pedestrian simulator powered by the social force model
https://github.com/srl-freiburg/pedsim_ros
BSD 2-Clause "Simplified" License
460 stars 170 forks source link

Eloquent dev #62

Open jginesclavero opened 4 years ago

jginesclavero commented 4 years ago

Basic Info

Info Please fill out this column
Ticket(s) this addresses Ticket https://github.com/srl-freiburg/pedsim_ros/issues/48
Primary OS tested on Ubuntu 18.04 ROS2 Eloquent
Robotic platform tested on Gazebo simulation of Tutlebot3

Description of contribution in a few bullet points

Screenshot from 2020-08-20 12-23-39

Future work that may be required in bullet points

tlind commented 4 years ago

Hi and thanks for the big pull request! I haven't worked with ROS2 yet, so I am curious why you changed the header file extensions (e.g. in pedsim_simulator) from .h to .hpp. Is there a technical requirement in ROS2 / ament that mandates that?

jginesclavero commented 4 years ago

Hi @tlind! It is a general guideline established by the OSRF and the ROS2 contributors, following the C++ style (.hpp and .cpp) instead of C style (.h and .c). You can check it in the migration guides, for example in the migration guide for rviz to rviz2.