Open jginesclavero opened 4 years ago
Hi and thanks for the big pull request! I haven't worked with ROS2 yet, so I am curious why you changed the header file extensions (e.g. in pedsim_simulator) from .h to .hpp. Is there a technical requirement in ROS2 / ament that mandates that?
Hi @tlind! It is a general guideline established by the OSRF and the ROS2 contributors, following the C++ style (.hpp and .cpp) instead of C style (.h and .c). You can check it in the migration guides, for example in the migration guide for rviz to rviz2.
Basic Info
Description of contribution in a few bullet points
Future work that may be required in bullet points