search

srl-labs / clabernetes

containerlab, but in kubernetes!
BSD 3-Clause "New" or "Revised" License
46 stars 8 forks source link

FR: Use containerlab' node labels to tag launcher deployment #162

Open hellt opened 1 month ago

hellt commented 1 month ago

https://containerlab.dev/manual/nodes/#labels

Besides the filtering/selection use case this would make it possible to create a special label format that would allow propagate certain labels to node selectors and/or tolerations.

The use case expressed here is to make sure that certain launcher pods could be scheduled to certain nodes using the nodeSelector.

Maybe node labels can be put to work for this use case.

carlmontanari commented 1 month ago

taking the clab labels and just putting them on the launcher deployments (like srl1 labels go to srl1 deployment labels, ceos1 labels to go ceos1 deployment labels, etc.) is a great idea imo. should do that regardless.

the only way I see changing the node selector setup right now would be to breaking change it to make it like the resources field where its a map of nodename-->our scheduling object. obviously I am down to break things at any point and also we are 0.x so I extra dont care 😁 . but thats probably the only way I think adding this would make sense.