search

srl-labs / containerlab

container-based networking labs
https://containerlab.dev
BSD 3-Clause "New" or "Revised" License
1.56k stars 266 forks source link

Add secondary IOL NVRAM bind. #2263

Closed kaelemc closed 1 month ago

kaelemc commented 1 month ago

IOL actually has two locations where it stores the NVRAM (essentially the saved configuration files).

Previously only one of the locations was bound from the container to the lab directory.

This PR adds the second NVRAM location as a bind to the container (as well as the logic check if we have to create the file so that we don't overwrite it).

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 51.16%. Comparing base (9e96472) to head (5b70ae7). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2263 +/- ## ========================================== - Coverage 51.18% 51.16% -0.03% ========================================== Files 172 172 Lines 16689 16694 +5 ========================================== - Hits 8542 8541 -1 - Misses 7235 7240 +5 - Partials 912 913 +1 ``` | [Files with missing lines](https://app.codecov.io/gh/srl-labs/containerlab/pull/2263?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=srl-labs) | Coverage Δ | | |---|---|---| | [nodes/iol/iol.go](https://app.codecov.io/gh/srl-labs/containerlab/pull/2263?src=pr&el=tree&filepath=nodes%2Fiol%2Fiol.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=srl-labs#diff-bm9kZXMvaW9sL2lvbC5nbw==) | `83.08% <100.00%> (+0.43%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/srl-labs/containerlab/pull/2263/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=srl-labs)