search

srl-labs / containerlab

container-based networking labs
https://containerlab.dev
BSD 3-Clause "New" or "Revised" License
1.56k stars 266 forks source link

Use default vCPU and RAM settings from vrnetlab #2285

Open kaelemc opened 2 weeks ago

kaelemc commented 2 weeks ago

2vCPU is frankly not enough for this node. Cisco docs say 4vCPU is the minimum required, with 4 vCPU I am seeing greatly improved boot times (still absurdly long though 😁).

https://www.cisco.com/c/en/us/td/docs/routers/virtual-routers/configuration/guide/b-xrv9k-cg/b-xrv9k-cg_chapter_011.html

hellt commented 2 weeks ago

It seems like it would be best to have a single source of the default cpu/mem settings between clab and vrnetlab

If memory serves me well, keeping it in the vrnetlab makes more sense like this https://github.com/hellt/vrnetlab/pull/261

And then every VR node might have the same default set for their respective constructor class, while clab has a way to overwrite it via env vars

kaelemc commented 2 weeks ago

Sounds good, so I should remove the env vars from the clab end so that they are only passed when the user manually sets them? Just want to be absolutely crystal clear :)

kaelemc commented 2 weeks ago

I'll make the changes on the vrnetlab side (maybe after the scrapli work is finished) then make the changes on the containerlab end.