search

srl-labs / containerlab

container-based networking labs
https://containerlab.dev
BSD 3-Clause "New" or "Revised" License
1.56k stars 267 forks source link

Common Label in example topologies #98

Closed steiler closed 4 years ago

steiler commented 4 years ago

I propose using a more general label in the example topologies. Right now we are using:

  kind_defaults:
    srl:
      image: srlinux:20.6.1-286

I propose to change this to either ´srlinux:latest´... or srlinux:containerlab, which would decouple the config from the actual GA release.

hellt commented 4 years ago

good suggestion, I will use :latest in the examples I create in #96

steiler commented 4 years ago

We should then extend the doc, such that the tag is to be set on setup, since on image import just the specific version tag is available.

docker tag srlinux:<VERSION-TAG> srlinux:latest
hellt commented 4 years ago

@steiler I have added the note and fixed the templates in https://github.com/srl-wim/container-lab/pull/96/commits/18b81c8698664d14e1ed8d3c6bf2e4f03599a4bd

What do you think?

steiler commented 4 years ago

Yes, that looks good to me. We should do the same with the already existing topologies in the lab-examples folder. Would you please incorporate that as part of your commit?

hellt commented 4 years ago

my goal is to discontinue the old lab examples as part of that PR. Which examples you are using from the old selection?

On Wed, Nov 4, 2020 at 3:16 PM Markus Vahlenkamp notifications@github.com wrote:

Yes, that looks good to me. We should do the same with the already existing topologies in the lab-examples folder. Would you please incorporate that as part of your commit?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/srl-wim/container-lab/issues/98#issuecomment-721756621, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABLKV5JECPTZQVNCWF4VMPDSOFO2JANCNFSM4TJ25KNA .

steiler commented 4 years ago

Opportunistically I've been simply utilising the wan-topo. But I don't have strong feelings about that. Lets get rid of it.

hellt commented 4 years ago

but its interesting to see what features of wan-topo I need to replicate I see that wan-topo had some lags between nodes, that was the idea, @henderiw?

Ideally I would like to know if we think about SRL in WAN today, what is the minimum viable topology would be useful to have? I can reuse wan-topo example, but now would be a good time to ask for changes in that topo

ADD1: so since the enhancement has been implemented I close this one, we can discuss the wan-topo another time