search

srl-labs / srl-controller

k8s controller for SR Linux nodes scheduled by KNE
BSD 3-Clause "New" or "Revised" License
16 stars 3 forks source link

enhancements to license binding #25

Closed hellt closed 10 months ago

hellt commented 2 years ago

Consider the following use cases for license provisioning:

1) If a user specifies a model that does not require a license then the tag of their image should not matter

2) If a user specifies a model that does require a license and the user has provided a single "catch all" license then the tag of their image should not matter

3) If a user specifies a model that does require a license and the user has not provided a license or has provided a license that matches a specific version other than the one they provided then the failure should clearly output during topology creation

4) treat ga tag the same as latest

_Originally posted by @alexmasi in https://github.com/srl-labs/srl-controller/pull/24#discussion_r995984363_

alexmasi commented 2 years ago

Any update on this? Bullet point 2 would be really helpful as we now ingest an image with a license but we reference it as the :ga (generally available) tag

hellt commented 2 years ago

Hi @alexmasi I replied in IM. As a summary: I will get to it eventually, sorry for the delay. It was not prioritized since we incorporated license into the image

carlmontanari commented 10 months ago

@hellt I think we can close this one if you're good w/ it after #40

hellt commented 10 months ago

ah I think this was also sorted before #40, (point 2), but seems with #40 it is even more robust