search

srl-labs / srl-controller

k8s controller for SR Linux nodes scheduled by KNE
BSD 3-Clause "New" or "Revised" License
16 stars 3 forks source link

Upgrade k8s client v0.25.0 and fix clientset to align with current k8s #28

Closed marcushines closed 1 year ago

marcushines commented 1 year ago

designs

hellt commented 1 year ago

Hi @marcushines Thanks for this PR. It seems I need to update the whole kubebuilder stuff to have a clean slate and move API/controller/clientset over. I started doing that and will take pieces related to clientset from this PR.

Do you happen to know why suddenly k8s 1.25? I see that other controllers aren't updated either

marcushines commented 1 year ago

we are at 1.23 internally so wanted to grab current to give largest window for not doing this again the other controllers have already moved to dynamic client so they are not breaking but will be upgrading them shortly as well just to keep things consistent

your controller was actually just incompatible with 1.23

hellt commented 1 year ago

@marcushines ack. This week I am away, but next week I plan to finish the move to kubebuilder v3 scaffolding and after that I will try incorporating the dynamic client parts from this PR to make it fly.