srl-labs / yang-browser

A web portal and a set of tools to bring joy to YANG consumption
https://yang.srlinux.dev
BSD 3-Clause "New" or "Revised" License
9 stars 0 forks source link

"srl_nokia-feat:future-0-0" #38

Closed bclasse closed 1 year ago

bclasse commented 1 year ago

Hi,

Some paths containing srl_nokia-feat:future-0-0 with another set of if-feature are being displayed on the browser - while they should not, as srl_nokia-feat:future-0-0 is not available on any platform. Can you please have a look ?

{
    "path": "/acl/mac-filter[name=*]/entry[sequence-id=*]/action/collect-stats",
    "path-with-prefix": "/srl_nokia-acl:acl/mac-filter[name=*]/entry[sequence-id=*]/action/collect-stats",
    "type": "boolean",
    "description": "Collect statistics for each entry of the ACL. If this is set to false no hardware resources are allocated to collecting statistics for this ACL entry.",
    "default": "false",
    "namespace": "urn:srl_nokia/acl",
    "if-features": [
      "srl_nokia-feat:future-0-0",
      "srl_nokia-feat:platform-7220-d2 or srl_nokia-feat:platform-7220-d3 or srl_nokia-feat:platform-7220-d4 or srl_nokia-feat:platform-7220-d5"
    ]
}

Note, oddly enough, this example is displayed for D3, D3L, D4, D5, D5T, 6(e), 10(e), but not the other platforms.

Also, if possible, could you also add this option in the list of selectable features?

Many thanks

hellt commented 1 year ago

Hi @siva19susi can you have a look at that one?

But we won't expose future-0-0, as this is not expected to be consumed by users.

hellt commented 1 year ago

@bclasse can you check now? the fix has been submitted

bclasse commented 1 year ago

Looks good to me - thank you both!