search

srl-labs / yang-browser

A web portal and a set of tools to bring joy to YANG consumption
https://yang.srlinux.dev
BSD 3-Clause "New" or "Revised" License
9 stars 0 forks source link

Add State/Config filters to YANG Compare #56

Closed bclasse closed 2 weeks ago

bclasse commented 5 months ago

Hi, it'd be cool to have a filter for state and config paths in the YANG Compare page. Sometimes users can be interested to just look at the new configurable paths rather than having the whole set of new paths (config+state).

bclasse commented 2 months ago

Thanks for adding this, there's just a small display bug. When selecting "RW - Config", it appears as "RW - State". Can you fix this ? Thanks!

image

siva19susi commented 2 months ago

@bclasse intention was to mention it is filtering Read Write State. But I see your point, what do you think would be a good common name for State and Config to represent the dropdown field?

siva19susi commented 2 months ago

@bclasse requested changes are live.

bclasse commented 2 months ago

Oh alright, I understand what you were doing there, it makes sense. Feel free to revert if you want to, now the new display isn't consistent with the 'Changes' option. For a common name, maybe 'Datastore', 'Data', 'Role', 'Permission' or 'Access' could fit?