search

srlabUsask / crhmcode

GNU General Public License v3.0
7 stars 3 forks source link

Crhm tsurface correction15 mar2023 #426

Closed loganxingfang closed 1 year ago

loganxingfang commented 1 year ago

Changes:

  1. added corrections for hru_tsf estimation in module tsurface.
  2. added description of module variation#5 in module glacier; this could be solution to the Issue #423.
jhs507 commented 1 year ago

These changes look good to me. Should other modelers weigh in or are the corrections just fixing an error?

jhs507 commented 1 year ago

@loganxingfang Just following up on this should this be merged or should other modelers weigh in?

loganxingfang commented 1 year ago

For issue mentioned about module variation#5 in module glacier, it needs to fixed; otherwise user cannot construct prj when selecting glacier#5, as it would crash.

For issue about hru_tsf estimation, it has been reviewed by Peter. The solution is also reviewed by John.

jhs507 commented 1 year ago

Okay this looks good to merge to me.

I will be working on a new release today and this should be included.

loganxingfang commented 1 year ago

Thank you Justin.