search

srlanalytics / bdfm

Bayesian dynamic factor model estimation and predictive statistics including nowcasting and forecasting
MIT License
5 stars 6 forks source link

Seas adj we #21

Closed christophsax closed 5 years ago

christophsax commented 5 years ago

I guess data.table must be properly imported.

At the same time, on Line 556, the object to overwrite was nn, rather than N, so perhaps your error was just that.

Anyway, I still will try to refactor the thing, perhaps we can do it efficiently without depending on data.table. But for the moment, let's keep it that way.

codecov-io commented 5 years ago

Codecov Report

Merging #21 into master will decrease coverage by 3.02%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #21      +/-   ##
==========================================
- Coverage    34.4%   31.38%   -3.03%     
==========================================
  Files           7        7              
  Lines        1558     1708     +150     
==========================================
  Hits          536      536              
- Misses       1022     1172     +150
Impacted Files Coverage Δ
R/SA_Programs.R 0% <0%> (ø) :arrow_up:
src/BDFM.cpp 54.42% <0%> (-0.89%) :arrow_down:
R/utils.R 1.56% <0%> (-3.71%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2f6cd20...736c98e. Read the comment docs.

christophsax commented 5 years ago

Agreed: this looks like a weak reason to keep such a big dependency.

It is fine to delete merged branches: They are still kept somewhere on GitHub, and can be undeleted:

image

That makes it easier to keep an overview of the active branches.