srlanalytics / bdfm

Bayesian dynamic factor model estimation and predictive statistics including nowcasting and forecasting

MIT License

5 stars 6 forks source link

Tweaks #39

Closed christophsax closed 5 years ago

christophsax commented 5 years ago

a little bit of clean up
progress indicator. experimental, perhaps we want it only if loud = TRUE? It's nice in interactive mode but it pollutes the output of reprex::reprex().

codecov-io commented 5 years ago

Codecov Report

Merging #39 into master will increase coverage by 2.2%. The diff coverage is 100%.

@@            Coverage Diff            @@
##           master      #39     +/-   ##
=========================================
+ Coverage   55.25%   57.45%   +2.2%     
=========================================
  Files           9        9             
  Lines        1609     1556     -53     
=========================================
+ Hits          889      894      +5     
+ Misses        720      662     -58

Impacted Files	Coverage Δ
R/PCdfm.R	`0% <ø> (ø)`	:arrow_up:
R/seas_utils.R	`60.21% <ø> (ø)`	:arrow_up:
R/MLdfm.R	`0% <ø> (ø)`	:arrow_up:
R/utils.R	`3.63% <ø> (+1.63%)`	:arrow_up:
R/BDFM.R	`52.02% <ø> (ø)`	:arrow_up:
src/BDFM.cpp	`72.26% <100%> (+1.24%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d785b9a...2ec7efe. Read the comment docs.

codecov-io commented 5 years ago

Codecov Report

Merging #39 into master will increase coverage by 2.09%. The diff coverage is 62.96%.

@@            Coverage Diff             @@
##           master      #39      +/-   ##
==========================================
+ Coverage   55.25%   57.34%   +2.09%     
==========================================
  Files           9        9              
  Lines        1609     1552      -57     
==========================================
+ Hits          889      890       +1     
+ Misses        720      662      -58

Impacted Files	Coverage Δ
R/PCdfm.R	`0% <ø> (ø)`	:arrow_up:
R/seas_utils.R	`60.21% <ø> (ø)`	:arrow_up:
R/utils.R	`3.63% <ø> (+1.63%)`	:arrow_up:
R/MLdfm.R	`0% <0%> (ø)`	:arrow_up:
R/bdfm.R	`52.02% <50%> (ø)`
R/dfm.R	`41.72% <53.84%> (+0.12%)`	:arrow_up:
src/BDFM.cpp	`72.18% <81.81%> (+1.16%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d785b9a...79e2138. Read the comment docs.

christophsax commented 5 years ago

Perhaps we could do the progress indicator only if verbose = TRUE, and set the default there to interactive()? This is TRUE in interactive mode but FALSE in reprex::reprex().

christophsax commented 5 years ago

@srlanalytics can we merge that first?

srlanalytics commented 5 years ago

Sorry, meant to before I even started working on the next branch...