Not a big thing, I would suggest that as a 'technical function', dfm_core should use the verbose R variable names, such as outlier_threshold. Renaming stuff is confusing, and we should do it only if we really need to. A place where it is ok to use short names is within the 'mathematical functions' (bdfm etc.), where we use matrix algebra and want to use the notation from the literature.
Not a big thing, I would suggest that as a 'technical function',
dfm_core
should use the verbose R variable names, such asoutlier_threshold
. Renaming stuff is confusing, and we should do it only if we really need to. A place where it is ok to use short names is within the 'mathematical functions' (bdfm
etc.), where we use matrix algebra and want to use the notation from the literature.