Closed christophsax closed 5 years ago
@christophsax, let me know if this looks OK and we can close this issue.
I will do another turn and may have some more question. So let's keep it open and assign to me.
It would be good if the object is specified in the beginning. E.g.,:
#' @param trans_prior m x n matrix; m: number of factors, n: number of lags. Prior B matrix in the
#' transition equation. Default is a matrix with 0. E.g., to use a random walk prior with m factors and
#' p lags, set `trans_prior = cbind(diag(1,m,m), matrix(0,m,m*(p-1)))`.
I currently have no idea how to construct these matrices.
What is this good for?
#' @param orthogonal_shocks return a rotation of the model with orthogonal
#' shocks and factors. This is useful ....
OK... see updates on arguments.
Ok for now
It would be nice to have a bit more info on these. Including some hint on what can be accomplished by manipulating it. See
@param obs_df
for an example.