srlearn / rnlp

Relational NLP: Convert text into relational facts.

https://rnlp.readthedocs.io/en/latest/

GNU General Public License v3.0

9 stars 5 forks source link

Small changes to index, .gitignore #14

Closed skinn009 closed 6 years ago

skinn009 commented 6 years ago

Added pycharm environment control files to .gitignore.

codecov-io commented 6 years ago

Codecov Report

Merging #14 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #14   +/-   ##
=======================================
  Coverage   98.26%   98.26%           
=======================================
  Files           7        7           
  Lines         231      231           
=======================================
  Hits          227      227           
  Misses          4        4

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d6735e9...96ae53b. Read the comment docs.

skinn009 commented 6 years ago

Can I do that?

On Fri, Aug 3, 2018 at 11:06 AM, Alexander L. Hayes < notifications@github.com> wrote:

@batflyer approved this pull request.

These look good, should be fine to merge into master.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/starling-lab/rnlp/pull/14#pullrequestreview-143242653, or mute the thread https://github.com/notifications/unsubscribe-auth/AWQ7T38iWrH1urYyuuQbLX2Lbe-C4YSuks5uNHUDgaJpZM4VuO4D .

hayesall commented 6 years ago

@skinn009 Yep. You should have a "Merge pull request" option now that the changes are approved, if it isn't appearing let me know (I was tweaking some access options when adding you and Yuqiao, but if it isn't appearing I should be able to fix it).

skinn009 commented 6 years ago

Edits to documentation.

skinn009 commented 6 years ago

Okay- I think I merged. Thanks.

Mike

On Fri, Aug 3, 2018 at 11:17 AM, Alexander L. Hayes < notifications@github.com> wrote:

@skinn009 https://github.com/skinn009 Yep. You should have a "Merge pull request" option now that the changes are approved, if it isn't appearing let me know (I was tweaking some access options when adding you and Yuqiao, but if it isn't appearing I should be able to fix it).

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/starling-lab/rnlp/pull/14#issuecomment-410303577, or mute the thread https://github.com/notifications/unsubscribe-auth/AWQ7T4kg9a-aHrFGxZpKjA18DN3EyhiEks5uNHemgaJpZM4VuO4D .