search

srlearn / rnlp

Relational NLP: Convert text into relational facts.
https://rnlp.readthedocs.io/en/latest/
GNU General Public License v3.0
9 stars 5 forks source link

Allow optional '-o' flag to be passed #21

Closed adamjsawicki closed 4 years ago

adamjsawicki commented 4 years ago

Fixes https://github.com/hayesall/rnlp/issues/9, add an output directory to be specified.

codecov-io commented 4 years ago

Codecov Report

Merging #21 into master will increase coverage by 0.16%. The diff coverage is 98.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #21      +/-   ##
==========================================
+ Coverage   95.73%   95.89%   +0.16%     
==========================================
  Files           9        9              
  Lines         305      317      +12     
==========================================
+ Hits          292      304      +12     
  Misses         13       13
Impacted Files Coverage Δ
rnlp/tests/rnlptests/test_parse.py 100% <100%> (ø) :arrow_up:
rnlp/tests/rnlptests/test_converter.py 100% <100%> (ø) :arrow_up:
rnlp/tests/rnlptests/test_textprocessing.py 100% <100%> (ø) :arrow_up:
rnlp/tests/tests.py 90.9% <66.66%> (-0.76%) :arrow_down:
rnlp/parse.py 98.19% <98.33%> (+0.15%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 10ecea4...3d464a5. Read the comment docs.

adamjsawicki commented 4 years ago

@hayesall Made the requested updates, as well as made some other Pythonic changes.

hayesall commented 4 years ago

LGTM! The general Python changes + the tearDown() is much cleaner too.

I've been using black for formatting more recently, standardizing to use its formatting suggestions might help make things more consistent in the future.

Thank you for the pull request!