Closed hayesall closed 6 years ago
Merging #7 into master will increase coverage by
43.12%
. The diff coverage is94.2%
.
@@ Coverage Diff @@
## master #7 +/- ##
===========================================
+ Coverage 55.14% 98.26% +43.12%
===========================================
Files 5 7 +2
Lines 214 231 +17
===========================================
+ Hits 118 227 +109
+ Misses 96 4 -92
Impacted Files | Coverage Δ | |
---|---|---|
rnlp/tests/rnlptests/test_textprocessing.py | 100% <100%> (ø) |
:arrow_up: |
rnlp/textprocessing.py | 100% <100%> (ø) |
:arrow_up: |
rnlp/tests/rnlptests/test_parse.py | 100% <100%> (ø) |
|
rnlp/tests/rnlptests/test_converter.py | 100% <100%> (ø) |
|
rnlp/__init__.py | 100% <100%> (+18.75%) |
:arrow_up: |
rnlp/parse.py | 96.19% <90.24%> (+79.97%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 78b2149...f7a2088. Read the comment docs.
This pull request re-factors the
makeIdentifiers()
function in parse.py and fixes a few fairly critical errors.makeIdentifiers
is now imported by default when rnlp is imported.parse.makeIdentifiers()
where the lateWordInSentence predicate was never created. In its place a second (and erroneous) lateSentenceInBlock predicate was created instead.text_string.strip(_punctuation)
worked in most simple cases, but certain punctuation marks within sentences were problematic for BoostSRL's parser.