srlearn / rnlp

Relational NLP: Convert text into relational facts.
https://rnlp.readthedocs.io/en/latest/
GNU General Public License v3.0
9 stars 5 forks source link

Bugfixing and Refactoring parse.py #7

Closed hayesall closed 6 years ago

hayesall commented 6 years ago

This pull request re-factors the makeIdentifiers() function in parse.py and fixes a few fairly critical errors.

codecov-io commented 6 years ago

Codecov Report

Merging #7 into master will increase coverage by 43.12%. The diff coverage is 94.2%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master       #7       +/-   ##
===========================================
+ Coverage   55.14%   98.26%   +43.12%     
===========================================
  Files           5        7        +2     
  Lines         214      231       +17     
===========================================
+ Hits          118      227      +109     
+ Misses         96        4       -92
Impacted Files Coverage Δ
rnlp/tests/rnlptests/test_textprocessing.py 100% <100%> (ø) :arrow_up:
rnlp/textprocessing.py 100% <100%> (ø) :arrow_up:
rnlp/tests/rnlptests/test_parse.py 100% <100%> (ø)
rnlp/tests/rnlptests/test_converter.py 100% <100%> (ø)
rnlp/__init__.py 100% <100%> (+18.75%) :arrow_up:
rnlp/parse.py 96.19% <90.24%> (+79.97%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 78b2149...f7a2088. Read the comment docs.