search

srm-kzilla / violet-air

Official source for Violet Air. An application to track the air quality of cities worldwide! Check out the tutorial at:
https://youtu.be/5l3HojhAH1s
12 stars 9 forks source link

Pressing back button skips a screen #11

Closed sachdeva-shrey closed 3 years ago

sachdeva-shrey commented 3 years ago

Description

Pressing the back button on the CityScreen takes back to the HomeScreen. It should take the user back to the MapView.

Screenshot

WhatsApp Image 2020-10-02 at 7 00 02 PM

kala2 commented 3 years ago

Hello, May i please?

varshaig1999 commented 3 years ago

hello @sachdeva-shrey can you please assign this to me?

sachdeva-shrey commented 3 years ago

Hey @kala2! I'll assign this on to you since you asked first. I'm sorry, @varshaig1999, we have a lot of issues open on our other repositories too which you might want to take up!

ericvicenti commented 3 years ago

One way of accomplishing this is by using the drawer navigator from React Navigation. This navigator will handle the back button and will also give us a handy drawer/sidebar in the city screen.

https://reactnavigation.org/docs/drawer-based-navigation/

Or this can be done by overriding the back button:

https://reactnavigation.org/docs/custom-android-back-button-handling/

On Fri, Oct 2, 2020 at 8:37 AM Shrey Sachdeva notifications@github.com wrote:

Hey @kala2 https://github.com/kala2! I'll assign this on to you since you asked first. I'm sorry, @varshaig1999 https://github.com/varshaig1999, we have a lot of issues open on our other repositories too which you might want to take up!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/srm-kzilla/violet-air/issues/11#issuecomment-702804422, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALKGTPCPXQEZQQA2LH2P7LSIXXSPANCNFSM4SBYH36A .

saa27 commented 3 years ago

Hey @sachdeva-shrey ! I would like to work on this. Can you assign it to me please?

sachdeva-shrey commented 3 years ago

Hey @saa27! Sure, it's all yours! :)