search

srm985 / mok-project

Multilingual Onscreen Keyboard Project
http://www.seanmcquay.com/mok-project.htm
MIT License
30 stars 8 forks source link

Numerals for Arabic/Urdu Scripts #45

Open yourfluffyface opened 5 years ago

yourfluffyface commented 5 years ago

Hi,

I'm using this keyboard for an Urdu language related project and it's great as far as I've tested it. However, as the numerals for most Eastern scripts are different, I updated my .klc file to incorporate Urdu numbers. I'm still having trouble with the direction the numbers appear because , currently, the numbers go from LTR instead of RTL (similar to the rest of the script).

Any help would be appreciated. Thanks!

urduUpdated.zip

srm985 commented 5 years ago

Greetings! I'll have a look. So the expected and normal behavior is that while writing in Urdu the numbers can be inline and will flow RTL?

yourfluffyface commented 5 years ago

I'm really really sorry, I was mistaken. The numbers go from left to right in both Urdu and Arabic scripts. Again, I'm really sorry about that!!!

On Wed, Mar 27, 2019, 6:51 PM Sean notifications@github.com wrote:

Greetings! I'll have a look. So the expected and normal behavior is that while writing in Urdu the numbers can be inline and will flow RTL?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/srm985/mok-project/issues/45#issuecomment-477377143, or mute the thread https://github.com/notifications/unsubscribe-auth/ASngxoDb4Sd7RDB7vAmQSorltJc-qP6aks5va_X5gaJpZM4cO6NE .

srm985 commented 5 years ago

So if I understand, there is no issue? Is that correct?

What about the update numerals? Does the current Urdu layout have the wrong numerals? Should I replace them with yours?

yourfluffyface commented 5 years ago

Yes, that is correct.

Urdu has its own numerals for each digit. The following is of the mapping of the numbers using a screenshot of the updated Urdu keyboard (urduUpdated.klc): [image: image.png]

Also, after changing the behavior of the enter key (to add a new line when pressed), the cursor would go to a new line but then go back to the beginning of text. Therefore, I had to force the focus to the end of text so that the enter key works in a conventional manner. It's not as relevant/a big issue, just something I came across.

Other than that, it seems to be working perfectly.

On Thu, Mar 28, 2019 at 12:05 AM Sean notifications@github.com wrote:

So if I understand, there is no issue? Is that correct?

What about the update numerals? Does the current Urdu layout have the wrong numerals? Should I replace them with yours?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/srm985/mok-project/issues/45#issuecomment-477439538, or mute the thread https://github.com/notifications/unsubscribe-auth/ASngxk0GzpzlR4YzFS-63bX-kdyazLbQks5vbD94gaJpZM4cO6NE .

srm985 commented 5 years ago

I have a couple of questions - perhaps you can help me understand them so I can create better Urdu support. Does Urdu always use the numerals in your updated file or does it ever use 0-9? I am trying to determine if I should replace the current Urdu file with yours or create a second one which is yours.

As far as LTR vs RTL, I guess Urdu is RTL so I'll be adding a check for that.

And finally, on the enter key, you are saying you wrote a custom callback to insert a new line but it wasn't placing the cursor correctly?

Edit Oh and one more question, how does it work when entering Urdu numerals into an input field which only allows numbers? Does this work or do you have to use 0-9?

yourfluffyface commented 5 years ago

Hi,

Urdu, conventionally, always uses its own numbers, never 0-9. Yes, initially it would go to the new line but then return to the beginning of the text (I don't know whether it was supposed to work that way or not). It behaved normally after I forced the focus at the end of the text.

https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail Virus-free. www.avast.com https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail <#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>

On Sun, Mar 31, 2019 at 6:17 PM Sean notifications@github.com wrote:

I have a couple of questions - perhaps you can help me understand them so I can create better Urdu support. Does Urdu always use the numerals in your updated file or does it ever use 0-9? I am trying to determine if I should replace the current Urdu file with yours or create a second one which is yours.

As far as LTR vs RTL, I guess Urdu is RTL so I'll be adding a check for that.

And finally, on the enter key, you are saying you wrote a custom callback to insert a new line but it wasn't placing the cursor correctly?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/srm985/mok-project/issues/45#issuecomment-478390569, or mute the thread https://github.com/notifications/unsubscribe-auth/ASngxuu_3tZ365dzMIuOoGmG0rqjQkPqks5vcTPogaJpZM4cO6NE .