search

srmagura / real-cancellable-promise

Cancellable promise library for JavaScript and TypeScript.
https://srmagura.github.io/real-cancellable-promise
MIT License
33 stars 2 forks source link

Fix `buildCancellablePromise` type signature #12

Closed ondrej-stanek-ozobot closed 11 months ago

ondrej-stanek-ozobot commented 11 months ago

We noticed that the signature of race was updated in commit 7f916808125859351b1cdee0331c61526afc2cdb (src/CancellablePromise.ts:77).

We propose to also update the signature of the buildCancellablePromise in the same manner.

This resolves issue with types encountered in the raceAndCancel PR #11.

We kindly ask to consider merging this type improvement independently of the PR #11.

ondrej-stanek-ozobot commented 11 months ago

Sorry, the issue is very convoluted and I am having hard time writing a test for it. I will submit this as a separate issue in case I will be able to write a test that clearly shows the issue. Closing this PR for now.