srmainwaring / asv_wave_sim

This package contains plugins that support the simulation of waves and surface vessels in Gazebo.
GNU General Public License v3.0
122 stars 34 forks source link

Noetic Setup #68

Closed MoffKalast closed 2 years ago

MoffKalast commented 2 years ago

Quick question, is there a way to get this built with Noetic or should I stop before waste a few hours trying?

Looking at the various branches it seems like it's either Melodic with 9 or Humble with Garden. What's so incompatible about Fortress/11?

srmainwaring commented 2 years ago

The master branch does not depend on ROS. The previous version for Gazebo11 did, and worked with Melodic. That branch may work with Noetic as there was only a weak dependency, mainly on the catkin build system. The master branch targets Garden as that version has full support for macOS / Metal. There are large namespace and library changes between Fortress and Garden that would require significant effort to backport, so it’s just Garden I’m afraid.

MoffKalast commented 2 years ago

Ah I see, there is in fact a feature/gazebo11 branch that I missed. I'll check that out. As for Garden vs Fortress, yeah that's what I figured might be the issue there.

Thanks.

srmainwaring commented 2 years ago

@MoffKalast I'll close this. If there's any maintenance work required to get the gazebo11 branch running add an issue and I'll take a look at it.

Edit

Seems that Noetic support came up previously, and another user has run successfully: https://github.com/srmainwaring/asv_wave_sim/issues/12#issuecomment-909006454