search

srmainwaring / wave_sim_vrx

This package contains plugins that support the simulation of waves in Gazebo.
Apache License 2.0
3 stars 0 forks source link

Any way you could port this to ROS Noetic? #1

Closed LFS-Robotics closed 1 year ago

LFS-Robotics commented 1 year ago

Any chance of a Noetic port of this ?

srmainwaring commented 1 year ago

@LFS-Engineering, I believe most of the functionality from this repo has now been incorporated into the vrx project directly.

This repo, wave_sim_vrx, is a hard fork of asv_wave_sim with all the GPL dependencies removed (and most of the functionality). The vrx team wanted to incorporate the approach used here to synchronise the visuals with the server physics and this repo was prepared to help with that. It's maintenance only I'm afraid and I'm not planning to port to Noetic as my focus is ROS2 Humble and Gazebo Garden. I'd be happy to accept a PR however if you are interesting in submitting a port yourself.

LFS-Robotics commented 1 year ago

Thanks for the quick response, understandable. Was just having issues with the asv_wave_sim configuration. But will keep trying to get that working.

srmainwaring commented 1 year ago

If you want some help with asv_wave_sim feel free to log an issue with a help tag. As I mentioned above the focus is mostly on ROS2 / Gazebo Garden and later as I support Ubuntu and macOS, and macOS support for ROS1 just got too difficult after macOS Catalina. There are a couple of branches of asv_wave_sim that do target Gazebo classic (9 and 11). The master branch no longer has any ROS dependency, except perhaps the build tool which is now colcon.

alexdrc00 commented 1 year ago

Just a quick question, @srmainwaring, has asv_wave_sim then been incorporated into vrx 2.0 or later releases? I have been testing changing wave parameters but I could not see any relevant visual changes on the waves nor a real displacement of the wamv. I just want to make sure what the issue is in case it has anything to do with a mistake in the installation on my side. Thanks

srmainwaring commented 1 year ago

Just a quick question, @srmainwaring, has asv_wave_sim then been incorporated into vrx 2.0 or later releases?

No, only the features mentioned above at the point this fork was created.

The main branch of asv_wave_sim has evolved significantly and there are currently no plans to incorporated it into VRX.

I will archive this repo to make it clear that it is available, but not being developed.