search

srmeyers / git-prefix

Visual Studio Code Extension - Prefix commit message with value in branch name.
https://marketplace.visualstudio.com/items?itemName=srmeyers.git-prefix
MIT License
22 stars 14 forks source link

[Bug] Clicking the prefix button in a Workspace toggles the repo's dropdown #29

Open atrudeau-vitall opened 8 months ago

atrudeau-vitall commented 8 months ago

Background Using a VSCode workspace you can add and work on multiple repositories, each repository you add to a workspace also has its own collapsable section in the source control panel.

Steps to reproduce

  1. Create a workspace with 2 or more repositories in VSCode
  2. Install + configure the git prefix extension
  3. Click the git prefix button in either repo's source control section

Expected output The commit message box for the selected repo is prefixed with the extension's prefix message, and each source control section's "collapsed" state is unaffected by clicking the git prefix button.

Actual Output The commit prefix is set correctly, however the source control section for the first repo in the workspace toggles (if it was open, it is now closed, vice versa) regardless of which git prefix button was clicked.

Environment VSCode Version: 1.86.0 (Universal) Electron: 27.2.3 ElectronBuildId: 26495564 Chromium: 118.0.5993.159 Node.js: 18.17.1 V8: 11.8.172.18-electron.0 OS: Darwin x64 21.6.0

johannes-schmitt commented 7 months ago

I'm experiencing the same issue. In my case it's not a workspace with multiple repositories but a git repository that contains git submodules. I assume it's the same root cause, as the Source Control panel shows multiple repositories.

dunnmj42 commented 6 months ago

I'm also experiencing this and have been for some time.

sr-tream commented 5 months ago

The reason is here. I think the author tried to set focus on input box, but instead of this, focus sets on repository widget and next select action collapse it.